Mobile: Update Heading block E2E test#46220
Merged
Conversation
|
Size Change: +1.8 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
2 tasks
fluiddot
approved these changes
Dec 1, 2022
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Mobile - Add Heading block integration test with snapshot * Mobile - Update Heading block empty snapshot * Update HTML test content of reusable block Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR:
Gutenberg mobile[Mobile] - Update Heading block E2E test wordpress-mobile/gutenberg-mobile#5296What?
This PR addresses a failure in one of the E2E tests where it uses the Heading block.
Why?
To solve the E2E failures in CI.
How?
By updating the empty Heading block placeholder in the test data file.
It also adds a small integration test that also does a snapshot check.
Testing Instructions
CI checks in wordpress-mobile/gutenberg-mobile#5296 should be green.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A