[Mobile] List/quote: Unwrap inner block when pressing Backspace at start#46115
Merged
ellatrix merged 3 commits intotry/list-quote-merge-graduallyfrom Nov 30, 2022
Merged
Conversation
added 3 commits
November 28, 2022 12:20
…t block merging functionality
…t unwrap the whole list but the selected first item
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
derekblank
approved these changes
Nov 30, 2022
Member
derekblank
left a comment
There was a problem hiding this comment.
LGTM! I was able to test successfully. 🚀
Member
Author
|
Hey @ellatrix 👋 should I merge this branch into yours or wait until you merge your branch into |
Member
|
@geriux You can merge it into my branch because I have failing tests without this, so can't merge into trunk rn. You have failing unit tests here though? |
Member
Author
@ellatrix It's weird because I only changed |
Member
|
Let's merge it into my branch and see what happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR is a follow-up of #45075 to make these changes work on mobile.
Why?
To have the same behavior in both web and mobile when unwrapping inner blocks when pressing
Backspaceat the start of the block.How?
By bringing the code changes to the
onMergefunctionality in the Block list. It also adds theList Itemblock in the mobiletransformationCategories.It also updates a test that has an outdated functionality with the current one.
Testing Instructions
BackspacekeyRepeat the same with the
Quoteblock.Screenshots or screencast