Conversation
Contributor
|
Thanks @Mamaduka, looks like a great solution (that didn't occur to me). I'll quickly test locally to verify that it really falls back to |
ockham
reviewed
Oct 25, 2022
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
Member
Author
|
@ockham, I got inspiration from your comment for this fix 😄 |
ockham
approved these changes
Oct 25, 2022
Contributor
ockham
left a comment
There was a problem hiding this comment.
LGTM! Thank you for fixing 😊
Contributor
|
@priethor @juanmaguitar This should also be included in GB 14.4 please 😊 |
tyxla
approved these changes
Oct 25, 2022
Contributor
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 739b2b0 |
ockham
added a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
This was referenced Oct 25, 2022
ockham
added a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
Contributor
|
Cherry-picked to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves #45254.
PR tries to fix failing PHPUnit tests.
How?
I've added a check to avoid calling the
gutenberg_resolve_assetsfor WP 6.0 and above. The__unstableResolvedAssetswill be generated using_wp_get_iframed_editor_assetsfor those versions.Testing Instructions
CI should be green.
Locally:
npm run test:unit:php -- --filter WP_Navigation_Page_Test