Navigation: Remove ellipses as menu icon options for now#44222
Merged
Navigation: Remove ellipses as menu icon options for now#44222
Conversation
|
Size Change: -123 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Thank you for fast reviews. Just to be sure, these icons have only ever been in the plugin, right? |
Contributor
|
Looks like #43674 was a recent change yes |
Contributor
Author
|
Thank you! The feature is awesome, and we'll be back with some great options! |
Contributor
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 9c154ed |
82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the two ellipsis icons from the navigation overlay menu options. Before:
After:
Why?
Given we can't easily allow uploading custom SVGs, we should heavily curate the defaults, but still not have too many. Perhaps 5 in total. In that light, the two ellipses are not the most compelling options we can offer, so we should remove them before they go out in 6.1 and become something we have to support long term.
That is to say: we should add options back, but we should add them carefully and deliberately and with confidence that they are icons we love. This could be a fun creative exercise as well, what 5 icons should we offer? A big plus? A minimalist dot? We can also add the kebab menu back, but if we do that, it should probably be 3 circles instead of 3 squares which is very much a block editor iconographic flair, more so than a general ellipsis pattern.
Testing Instructions
Please test the navigation block, click the gray preview area, and observe only two icons.