Fix naming collisions with WordPress 6.1#44100
Merged
cbravobernal merged 4 commits intotrunkfrom Sep 15, 2022
Merged
Conversation
Compatibility code should be prefixed with gutenberg_.
…tions should use the gutenberg_ prefix.
37 tasks
gziolo
approved these changes
Sep 14, 2022
Member
gziolo
left a comment
There was a problem hiding this comment.
Thank you for this refactoring 👍
cbravobernal
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Rename filter_out_block_nodes to gutenberg_filter_out_block_nodes. Compatibility code should be prefixed with gutenberg_. * Deprecate wp_enqueue_block_view_script in Gutenberg as Gutenberg functions should use the gutenberg_ prefix. * Fix CS. * Revert the changes back. Why? Please see https://github.com/WordPress/gutenberg/blob/trunk/lib/README.md#prefer-the-wp-prefix
Contributor
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Rename filter_out_block_nodes to gutenberg_filter_out_block_nodes. Compatibility code should be prefixed with gutenberg_. * Deprecate wp_enqueue_block_view_script in Gutenberg as Gutenberg functions should use the gutenberg_ prefix. * Fix CS. * Revert the changes back. Why? Please see https://github.com/WordPress/gutenberg/blob/trunk/lib/README.md#prefer-the-wp-prefix
Contributor
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 34f8b90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to rename Gutenberg functions that have naming collisions with Core.
Why?
All PHP functions located in the
lib/compatfolder should use thegutenberg_prefix.How?
This PR doesn't modify existing functionality, but can be considered as refactoring.
It renames existing methods to ensure good naming practices.
Testing Instructions
No testing is needed.
This PR refactors existing code.
As an additional precaution, make sure that the unit tests pass.
Screenshots or screencast