Global styles: filter block level styles before compiling global stylesheet#42207
Merged
Global styles: filter block level styles before compiling global stylesheet#42207
Conversation
… call gutenberg_get_global_stylesheet() otherwise global styles won't filter out the block styles that are later enqueued.
aaronrobertshaw
approved these changes
Jul 7, 2022
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for fixing this @ramonjd 👍
This PR tests as advertised
✅ Could replicate the issue on trunk
✅ After checking out this PR branch the duplicates were gone
✅ Tested using supplied snippets, different dynamic and static blocks, with different themes, and in both; site and block editors.
LGTM 🚢
| Before | After |
|---|---|
 |
 |
Contributor
|
Thanks for fixing this! |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42206
What? Why? How?
Since #42005, global block styles are enqueued twice:
global-styles-inline-cssThis causes duplicate styles in
styles.blocks[ $block_name ]rendered to the HTML.The
gutenberg_get_style_nodesfilter has to be registered before we callgutenberg_get_global_stylesheet()otherwise global styles won't filter out the block styles that are later enqueued.Testing Instructions
Add some block styles to your theme.json. Any block will do.
I'm using emptytheme and the Social links block as an example.
Example theme.json
{ "version": 2, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" } }, "styles": { "spacing": { }, "blocks": { "core/social-links": { "spacing": { "blockGap": "55px", "margin": "100px", "padding": "150px" }, "color": { "text": "red", "background": "yellow" } } } }, "patterns": [ "short-text-surrounded-by-round-images", "partner-logos" ] }Create a post with that block and publish it.
Example block code
Inspect the block HTML and see that the styles are NOT applied twice.