Global Styles: Always load block CSS from __experimentalStyle#42005
Merged
Global Styles: Always load block CSS from __experimentalStyle#42005
Conversation
draganescu
approved these changes
Jun 28, 2022
Contributor
draganescu
left a comment
There was a problem hiding this comment.
The code looks like it does what the PR says and I tested for the fixed Toujours bug which is gone with this patch.
Contributor
Author
|
This was relevant to a different PR, sorry! |
This was referenced Jul 7, 2022
37 tasks
Member
|
There is a conversation at core about how this works for classic themes, see https://core.trac.wordpress.org/ticket/56467#comment:408 @scruffian @draganescu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We need to always load the styles from __experimentalStyle, not just when assets are being split.
Why?
This needs to happen so that the __experimentalStyle rules are always applied.
How?
We attach the block styles to the end of the global styles CSS.
Testing Instructions
Fixes Automattic/wp-calypso#64994
Screenshots or screencast
@WordPress/block-themers