Update the block popover position as we scroll the container#41402
Merged
ntsekouras merged 1 commit intotrunkfrom May 31, 2022
Merged
Update the block popover position as we scroll the container#41402ntsekouras merged 1 commit intotrunkfrom
ntsekouras merged 1 commit intotrunkfrom
Conversation
|
Size Change: +21 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 27, 2022
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
This seems to have fixed the issue 🎉
Before:
toolbar.position.mp4
After:
toolbar.mp4
ntsekouras
approved these changes
May 31, 2022
andrewserong
reviewed
Jun 3, 2022
| __unstableSlotName = SLOT_NAME, | ||
| __unstableObserveElement, | ||
| __unstableForcePosition, | ||
| __unstableShift = false, |
Contributor
There was a problem hiding this comment.
It looks like switching this to default to false caused a small regression for the Tooltip component which relies on the shift behaviour to prevent the Tooltip from causing the editor to overflow. I've opened up a separate PR to opt-in to the __unstableShift for the Tooltip in #41524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #41156
What?
In the site editor, if you select a block and scroll the page, you'll notice that the block toolbar doesn't stick by the block element. This PR fixes that.
How?
The behavior here (update on scroll) was present in the original Popover implementation, this just brings it back.
Notes
Testing Instructions
1- Navigate to the site editor
2- Select a block
3- scroll the canvas
4- the block popover should stay by the block.