Components: refactor Autocomplete to pass exhaustive-deps#41382
Merged
Components: refactor Autocomplete to pass exhaustive-deps#41382
Autocomplete to pass exhaustive-deps#41382Conversation
44 tasks
|
Size Change: +11 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
May 27, 2022
Contributor
There was a problem hiding this comment.
Code changes LGTM 🚀
There are no unit tests and no Storybook examples for this component, which gives us a bit less confidence when making changes. We should add those soon-ish — at least the unit tests before the TypeScript migration.
I gave the component a quick look in the editor
but it's probably better if you could give it a second look too, before merging (given the lack of unit tests).
e7ebfd1 to
7a4e125
Compare
Contributor
Author
|
Thanks @ciampo! The lack of stories or tests gave me pause as well, but I also had good results from manual testing. I also took the slash inserter for a spin and that's working as expected as well so I think we're in good shape 🤞 Thanks again for the review! |
…e `onChangeOptions`
…ion` `useCallback` dependency arrays
7a4e125 to
720c7c4
Compare
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
* update `AutoCompleterUI` `useLayoutEffect` dependency array to include `onChangeOptions` * update `AutoCompleterUI` native.js `useLayoutEffect` and `startAnimation` `useCallback` dependency arrays * update `useAutocomplete` `useEffect` dependency array * Autocomplete: rebase and fix changelog merge conflict
This was referenced Jun 14, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Autoompletecomponent to satisfy theexhaustive-depseslint ruleWhy?
Part of the effort in #41166 to apply
exhuastive-depsto the Components packageHow?
AutocompleterUI
onChangeOptionsto theuseEffectdependency arrayAutocompleterUI native.js
onChangeOptionsandstartAnimationto theuseEffectdependency arrayanimationValueandresettostartAnimation'suseCallbackuseAutoComplete
AutocompleterUI,autocompleter,completers,recordandfilteredOptions.lengthto theuseEffectdependency arrayTesting Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/autocomplete