getBlockTransformItems: Support single block object#40718
Merged
Conversation
|
Size Change: +4 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Apr 29, 2022
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good, thanks George! We could add a tiny unit test for that maybe, but not a big deal 😄
Member
Author
Test that checks that the block object also works or something different? |
Contributor
What you already did 😄, thanks! |
Contributor
|
Added label "needs-dev-note' to flag this for WordPress 6.1 release documentation. @Mamaduka it does seem to just need a mention in the "But there is more" section of the Field Guide, rather than a section in a miscellaneous Dev note post? What do you think? |
Member
Author
|
This doesn't need a dev note. There a no plugins affected by it, and the updated argument types are documented in the handbook. |
Contributor
|
Please don't remove label before the release or at all. Just add a comment why it doesn't need it. If ut' not listed on the tracking issue add the PR number to the comment on the tracking issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR updates
getBlockTransformItemsselectorblocksarguments. Now it allows passing a single object or array of objects. This matches howgetBlocksByClientIdworks.Why?
When trying to get a transformation for a single block, we often have to pass blocks argument like this -
[ getBlock( clientId ) ]. If arguments aren't referentially equal, thecreateSelectorreturns the new value and re-rerenders the component. This can affect performance if left unchecked.Discovered while working on #40696.
How?
The blocks argument now is cast into an array inside the selector.
Testing Instructions
Tests should be passing.