[Mobile] Quote - Use nested blocks#40439
Merged
geriux merged 2 commits intoupdate/quote-to-nestedfrom Apr 26, 2022
Merged
Conversation
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
oandregal
reviewed
Apr 19, 2022
Member
There was a problem hiding this comment.
I've already brought back these changes (were lost during rebasing) at a993839
9f5e5cc to
551c2f8
Compare
a993839 to
99ab603
Compare
Member
|
I see there're some unit tests from mobile failing at #25892 I presume they'll be fixed by this PR? |
Member
Author
Yup! This one will fix that |
aed1fb5 to
8cfeb7c
Compare
Member
Author
|
Hey @jhnstn 👋 let me know if you can check this PR, it doesn't introduce new changes. It just removes some code we added. Thanks! |
jhnstn
approved these changes
Apr 25, 2022
Contributor
jhnstn
left a comment
There was a problem hiding this comment.
Changes look good, I didn't notice any issues testing 👍
added 2 commits
April 26, 2022 11:38
… get the first element which is the main list
551c2f8 to
dfc061b
Compare
oandregal
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Mobile - Remove Quote V2 check on registration * Mobile - Tests - initializes the editor: With inner blocks we need to get the first element which is the main list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up of #40133 to remove some Quote block checks to support both versions.
Why?
This PR #25892 enables Quote V2 by default so these cheks are no longer needed.
How?
By removing the extra checks.
Testing Instructions
Test case 1
Test case 2
Test case 3
Screenshots or screencast
Quote block with text and background colors.
Quote block with alignment set