[Multi-selection]: Copy whole block when selection is collapsed#40374
Merged
ntsekouras merged 2 commits intoApr 15, 2022
Conversation
|
Size Change: +55 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Apr 15, 2022
adamziel
pushed a commit
that referenced
this pull request
Apr 19, 2022
* [Multi-selection]: Copy whole block when selection is collapsed * rename var to shouldHandleWholeBlocks
Contributor
|
This was cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Based on @mcsf ' s #40098 (comment)
Currently if we had a collapsed selection we would expand the selection to the whole block and that required pressing
cmd +v/ctwice to copy the whole block. This PR checks about a collapsed selection and properly copies/cuts the whole block in that caseHow?
I added a new
__unstableIsSelectionCollapsedselector and not integrated the checks with__unstableIsFullySelectedto better separate the concerns.Testing Instructions