Conditionally set secondary sidebar landmark region labels#40296
Merged
Conversation
|
Size Change: -17 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Apr 13, 2022
kevin940726
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
Although, probably we wouldn't want to mutate module-scope variable like that. Instead, we could define a local variable in the component to make it explicit.
let secondarySidebarLabel;
if (isListViewOpened) {
secondarySidebarLabel = __('List View');
} else if (isInserterOpened) {
secondarySidebarLabel = __('Block Library');
}
return (
<InterfaceSkeleton
labels={{
...interfaceLabels,
secondarySidebar: secondarySidebarLabel,
}}
/>
);
Member
Author
|
Thanks, @kevin940726. I've updated the logic. |
adamziel
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Conditionally set secondary sidebar landmark region labels * Don't mutate the object
Contributor
|
This was cherry-picked to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40250.
PR correctly sets secondary sidebar region labels depending on the sidebar open.
Testing Instructions
.interface-interface-skeleton__secondary-sidebarclass.Screenshots or screencast