useBlockLock: Always check inherited 'templateLock' status#40263
Merged
Conversation
Member
Author
|
@critterverse, I think we originally wanted to hide lock status from the toolbar for this case. But this would be the correct visual representation of the block lock status. @talldan, unfortunately, Widget Areas will display the lock icon in the sidebar. I'm not sure if we can fix this without adding a special case to the check.
|
|
Size Change: -28 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
b538766 to
ca76abd
Compare
Member
|
Do we need to backport this bug fix for WordPress 6.0 release? I like how this hook gets simpler with the changes proposed 👍 |
Contributor
Interesting. Maybe that's ok. What do you think @critterverse? It might be another thing to add to the discussion at #33254. |
talldan
approved these changes
Apr 13, 2022
Contributor
There was a problem hiding this comment.
Thanks @Mamaduka. This fixes things for me.
Do we need to backport this bug fix for WordPress 6.0 release?
I think it'll need to be in the current Gutenberg release candidate because of the change to the function signature (and implicit behaviour of the function). So I guess that'll mean it ends up in 6.0.
Actually, I don't think this is a public API (yet), so ignore what I just said 😄 .
I think it's ok to backport at a later date.
Member
Author
Contributor
|
This was cherry-picked to |
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR updates
useBlockLockto always check the parent's inheritedtemplateLockstatus.Props, @talldan, for discovering the issue.
Why?
The
templateLockprovides default lock status on post type or block level. Without this check, blocks can be incorrectly represented as locked or unlocked.How?
Removed
checkParentargument.Testing Instructions
Exampe Post Type
Screenshots or screencast