Migrate document settings test to playwright#40258
Merged
Merged
Conversation
talldan
commented
Apr 12, 2022
talldan
commented
Apr 12, 2022
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
kevin940726
reviewed
Apr 12, 2022
kevin940726
left a comment
Member
There was a problem hiding this comment.
Very well done! Left some nitpicks. Thanks for working on this!
Contributor
Author
|
@kevin940726 Thanks for the review, the feedback should all be addressed |
kevin940726
approved these changes
Apr 13, 2022
kevin940726
left a comment
Member
There was a problem hiding this comment.
Mostly looks good! Just some nitpicks left :)
02cb4c7 to
64cb3d6
Compare
Contributor
Author
|
The failing query block puppeteer test is also failing in This PR doesn't affect it any way, so I'm merging it. |
adamziel
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Add ported version of site editor document settings test * Delete old puppeteer test * Fix test title, not a template part being tested * Use the spec suffix * Rename test description * Remove the EditorTitle utility class * Remove unnecessary deletion of templates and template parts * Improve selectors * use toHaveText * Select the iframe using its title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses a tiny tiny part of #38851
Migrates the 'document settings' test over to playwright.
Hopefully fixes #37085, fixes #36989
How?
I did the following
visitSiteEditorpage util.Testing Instructions
It is tests