Skip to content

Block Library: Deprecate the Post Comments block#40167

Merged
ZebulanStanphill merged 2 commits intotrunkfrom
update/hide-post-comments-block
Apr 8, 2022
Merged

Block Library: Deprecate the Post Comments block#40167
ZebulanStanphill merged 2 commits intotrunkfrom
update/hide-post-comments-block

Conversation

@DAreRodz
Copy link
Copy Markdown
Contributor

@DAreRodz DAreRodz commented Apr 7, 2022

What?

Removes the Post Comments block from the inserter, now that we have Comments Query Loop to replace it.

Why?

That block is being replaced with Comments Query Loop.

How?

Simply adding "inserter": false in block.json. The title and description have been updated as well to reflect that the block is deprecated.

Testing Instructions

  1. Open a Post or Page, or go to any template.
  2. Check that the Post Comments block doesn't appear anymore.
  3. Add a Post Comments block using the Code Editor.
  4. Check that the title and description of the block tell the block is deprecated.

Screenshots or screencast

Searching in the block inserter:

Screenshot 2022-04-08 at 11 01 42

Block information card:

Screenshot 2022-04-08 at 11 03 06

Copy link
Copy Markdown
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I believe the title and description should also be updated, like we did for the post comment block?
#36032

@DAreRodz DAreRodz added the [Feature] Blocks Overall functionality of blocks label Apr 8, 2022
@DAreRodz
Copy link
Copy Markdown
Contributor Author

DAreRodz commented Apr 8, 2022

Yup, that would be much better. Thanks for noticing, @carolinan. 😊

@DAreRodz DAreRodz added [Type] Enhancement A suggestion for improvement. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) and removed [Feature] Blocks Overall functionality of blocks labels Apr 8, 2022
@DAreRodz DAreRodz changed the title Post Comments: Hide block in the inserter Block Library: Deprecate the Post Comments block Apr 8, 2022
@DAreRodz DAreRodz requested a review from carolinan April 8, 2022 09:07
@ZebulanStanphill ZebulanStanphill merged commit 93c3914 into trunk Apr 8, 2022
@ZebulanStanphill ZebulanStanphill deleted the update/hide-post-comments-block branch April 8, 2022 19:29
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 8, 2022
adamziel pushed a commit that referenced this pull request Apr 11, 2022
* Remove Post Comments from the inserter

* Update block's title and description
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Apr 11, 2022

This PR was cherry-picked for Gutenberg plugin release v13.0 and WordPress 6.0 Beta 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants