Use wp_unique_id() instead of uniqid() to generate CSS class names#38891
Merged
Use wp_unique_id() instead of uniqid() to generate CSS class names#38891
wp_unique_id() instead of uniqid() to generate CSS class names#38891Conversation
Mamaduka
approved these changes
Feb 18, 2022
Member
Mamaduka
left a comment
There was a problem hiding this comment.
This looks good 👍
On the client-side, we're using useInstanceId to generate unique class names, which works in similar manner as wp_unique_id
Member
Author
|
Should this get ported into core trunk for the next maintenance release (i.e. 5.9.2)? |
Member
|
Added label for backporting. |
2 tasks
Mamaduka
pushed a commit
that referenced
this pull request
Mar 29, 2022
#38891) * Use wp_unique_id() instead of uniqid() to generate CSS class names * Fix elements test by upadting pattern in make_unique_id_one
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 29, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. See #55474. Built from https://develop.svn.wordpress.org/trunk@53012 git-svn-id: http://core.svn.wordpress.org/trunk@52601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 29, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. Merges [53012] to the 5.9 branch. See #55474. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@53013 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 29, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. Merges [53012] to the 5.9 branch. See #55474. Built from https://develop.svn.wordpress.org/branches/5.9@53013 git-svn-id: http://core.svn.wordpress.org/branches/5.9@52602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Mar 29, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. See #55474. Built from https://develop.svn.wordpress.org/trunk@53012 git-svn-id: https://core.svn.wordpress.org/trunk@52601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Mar 29, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. Merges [53012] to the 5.9 branch. See #55474. Built from https://develop.svn.wordpress.org/branches/5.9@53013 git-svn-id: https://core.svn.wordpress.org/branches/5.9@52602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This was referenced Apr 1, 2022
36 tasks
2 tasks
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. Merges [53012] to the 5.9 branch. See #55474. Built from https://develop.svn.wordpress.org/branches/5.9@53013
VenusPR
pushed a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
…ass names. Backports changes from WordPress/gutenberg#38891. See WordPress/gutenberg#38889. Props westonruter, mamaduka. Merges [53012] to the 5.9 branch. See #55474. Built from https://develop.svn.wordpress.org/branches/5.9@53013 git-svn-id: http://core.svn.wordpress.org/branches/5.9@52602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38889.
Description
Testing Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).