Add classic menus to menu switcher#38168
Merged
noisysocks merged 4 commits intotrunkfrom Jan 24, 2022
Merged
Conversation
|
Size Change: +44 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jan 24, 2022
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Code looks good and dropdown is working well 👍
noisysocks
approved these changes
Jan 24, 2022
Member
noisysocks
left a comment
There was a problem hiding this comment.
The code looks good and it tests well for me locally 👍
I double checked that we're not introducing any new strings 👍
I think it's a good solution for 5.9 given the time and string constraints 👍
I think the Tools heading might be unnecessary. Your call.
| } ) } | ||
| </MenuGroup> | ||
| ) } | ||
| <MenuGroup label={ __( 'Tools' ) }> |
Member
There was a problem hiding this comment.
What do you think about removing this label? I think Create new menu and Manage menus are clear enough to not need the additional context.
Contributor
Author
There was a problem hiding this comment.
I think I'll leave it. To me it feels cleaner to me to consistently have headings when there are multiple groups like this.
If only there were designers in this timezone we could ask 😄
Member
There was a problem hiding this comment.
I also like using different groups for Classic and Block menus.
Member
There was a problem hiding this comment.
Cool, your call.
If only there were designers in this timezone we could ask 😀
😅 yes unfortunately there wouldn't be enough time to do the backports if we wait. I put #36311 into the 5.9.x project board so that we can iterate asap.
Mamaduka
reviewed
Jan 24, 2022
packages/block-library/src/navigation/use-convert-classic-menu.js
Outdated
Show resolved
Hide resolved
noisysocks
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Add classic menus to switch menu dropdown * Preload entities * Hide classic menus when there are none * Memoize callback
Contributor
Contributor
|
Tested the backport of this fix in Core's 5.9 branch and can confirm this does fix the issue to unblock users upgrading to 5.9 and a block theme. Amazing work @talldan 👏 🌟 Thank you everyone for quickly resolving this user workflow issue! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38166
How has this been tested?
Expected: The classic menu should be converted to a block menu
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).