Gallery block: Remove warning notice about mobile version required#37842
Merged
glendaviesnz merged 2 commits intotrunkfrom Jan 12, 2022
Merged
Gallery block: Remove warning notice about mobile version required#37842glendaviesnz merged 2 commits intotrunkfrom
glendaviesnz merged 2 commits intotrunkfrom
Conversation
|
Size Change: -1.15 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 11, 2022
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Good thinking @glendaviesnz, I think it makes sense to remove the notice at this stage. Tested and confirmed that with my local storage cleared, the mobile gallery warning no longer appears and the gallery behaves as expected (new and existing galleries, adjusting gallery and image level settings, adding and removing images, etc), and that the block-library package doesn't use @wordpress/interface anywhere else 👍
LGTM, but let's see what other folks think, too 🙂
noisysocks
pushed a commit
that referenced
this pull request
Jan 17, 2022
…37842) Co-authored-by: Glen Davies <glen.davies@a8c.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: Automattic/wp-calypso#59560
In a small number of instances, the one-time notice about the Gallery mobile version issue displays multiple times every time a gallery is added or edited. It is not possible to replicate this, so difficult to work out how to prevent it.
It appears that for a very small number of users the value that toggles this message off is not sent to the store, but with no easy way to replicate it is not possible to work out the cause of that or a workaround.
Given that the number of mobile users on < 18.2 will should now be reduced considerably since this message was added, combined with the risk of this issue affecting a large number of users if it goes out in WP5.9 this PR removes the message completely.
To test
Screenshots
Before:
After:
