Build: Fix package dependencies issues discovered with pnpm#37396
Merged
Build: Fix package dependencies issues discovered with pnpm#37396
Conversation
0978eab to
eb98ae0
Compare
Closed
eb98ae0 to
80b7d76
Compare
Props to @youknowriad to fixing all those subtle bug while exploring pnpm in Gutenberg with #37324.
80b7d76 to
d166e55
Compare
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 15, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
I think there are more missing deps (see failures in tests in pnpm branch) but this is a good start.
Member
Author
I landed more fixes so you might want to rebase your branch and test again. I can tackle remaining issus as they pop up 👍🏻 |
dcalhoun
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Dec 16, 2021
The outdated packages resulted in the following CI failure. ``` TypeError: snapshotResolver.resolveSnapshotPath is not a function at Object._default [as default] (node_modules/jest-jasmine2/build/setup_jest_globals.js:101:41) ``` These updates were completed to resolve the error and mirror updates within the `gutenberg` submodule, which updated `jest-snapshot`: WordPress/gutenberg#37396 The cause of the error is a breaking change that landed in `jest-snapshots@27`: jestjs/jest#8829
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Props to @youknowriad to fixing all those subtle bug while exploring pnpm in Gutenberg with #37324.
This PR improves how we define npm dependencies in the Gutenberg project.
How has this been tested?
npm iandnpm run build.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).