Site Editor: Document Actions: add SR text to heading 1#37271
Merged
kevin940726 merged 2 commits intoWordPress:trunkfrom Dec 10, 2021
alexstine:add/sr-text-to-h1-editor
Merged
Site Editor: Document Actions: add SR text to heading 1#37271kevin940726 merged 2 commits intoWordPress:trunkfrom alexstine:add/sr-text-to-h1-editor
kevin940726 merged 2 commits intoWordPress:trunkfrom
alexstine:add/sr-text-to-h1-editor
Conversation
kevin940726
approved these changes
Dec 10, 2021
Member
kevin940726
left a comment
There was a problem hiding this comment.
LGTM 👍
Maybe it'll be better to combine "Editing:" and the title together into a single translated text though, so that different locale can rearrange the order of them. But we can do that as a follow-up if needed.
Member
|
E2E tests are failing and seem related to this PR though. |
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Site Editor: Document Actions: add SR text to heading 1. * Try to fix E2E.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Site Editor, I added the screen reader text before the main heading 1 in to the heading 1 that way all text is read. Text should still remain visually hidden but the page should flow much better for screen reader users.
How has this been tested?
I tested using NVDA screen reader in Firefox on Windows 10.
Screenshots
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).