Skip to content

Revert "Site Editor: Set the <title> on the list page to be same as the CPT name"#37270

Merged
noisysocks merged 1 commit intotrunkfrom
revert-36805-fix/title-on-site-editor-list-page
Dec 10, 2021
Merged

Revert "Site Editor: Set the <title> on the list page to be same as the CPT name"#37270
noisysocks merged 1 commit intotrunkfrom
revert-36805-fix/title-on-site-editor-list-page

Conversation

@noisysocks
Copy link
Copy Markdown
Member

Reverts #36805

As @youknowriad notes in #36805 (comment), this isn't necessary now that this screen uses client side routing.

To test:

  1. Open the site editor.
  2. Open the W menu.
  3. Browse to Templates or Template Parts.
  4. Notice that the window title is Templates or Template Parts.

@noisysocks noisysocks added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP Beta/RC [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Dec 10, 2021
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noisysocks noisysocks merged commit 8325a80 into trunk Dec 10, 2021
@noisysocks noisysocks deleted the revert-36805-fix/title-on-site-editor-list-page branch December 10, 2021 05:36
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 10, 2021
noisysocks added a commit that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants