Move duotone palette to the bottom of global styles gradients#37253
Merged
noisysocks merged 1 commit intotrunkfrom Dec 13, 2021
Merged
Move duotone palette to the bottom of global styles gradients#37253noisysocks merged 1 commit intotrunkfrom
noisysocks merged 1 commit intotrunkfrom
Conversation
|
Size Change: -3 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 9, 2021
| slugPrefix="custom-" | ||
| /> | ||
| <div> | ||
| <Heading className="edit-site-global-styles-gradient-palette-panel__duotone-heading"> |
Contributor
There was a problem hiding this comment.
The Subtitle component of Global Styles was written to avoid defining the styles and classes for each heading, we should probably just use it here and for the vertical spacing we should use Stack instead of custom margins
Member
There was a problem hiding this comment.
Hi @youknowriad, the subtitle component does not provide the same visual we want here according to the mockups:
Subtitle:
What we have:
Should we use the subtitle for all the palette titles even though there is a small difference when compared to the mockups?
Contributor
There was a problem hiding this comment.
@jorgefilipecosta Updating makes sense to me, the important thing is that be consistent across all global styles panels.
Member
Author
There was a problem hiding this comment.
We should fix the component, it should render smaller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duotone gradients should not have that much prominence in the UI.