Remove 4 instances of 'gutenberg' text domain from WordPress core#37229
Merged
aristath merged 7 commits intoWordPress:trunkfrom Dec 13, 2021
Merged
Remove 4 instances of 'gutenberg' text domain from WordPress core#37229aristath merged 7 commits intoWordPress:trunkfrom
aristath merged 7 commits intoWordPress:trunkfrom
Conversation
Use sprintf() to combine the string with the $label.
Use sprintf() to combine the string with the $label.
Mamaduka
reviewed
Dec 10, 2021
ocean90
requested changes
Dec 11, 2021
Thanks for feedback!
Thanks for feedback!
Member
|
Hi, @ocean90 Can we merge this PR? |
aristath
approved these changes
Dec 13, 2021
Member
|
All comments were addressed. I reviewed the commit and it looks good, fixing the issue at hand. No failing tests, so I went ahead and merged it 👍 |
noisysocks
pushed a commit
that referenced
this pull request
Dec 14, 2021
…7229) * Remove text domain, set string once. Use sprintf() to combine the string with the $label. * Remove text domain, set string once. Use sprintf() to combine the string with the $label. * Update variable name and translator text. Thanks for feedback! * Update variable name and translator comment. Thanks for feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37228
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).