E2E: Retry login again after a bad nonce request to prevent intermittent test failures #37219
Merged
E2E: Retry login again after a bad nonce request to prevent intermittent test failures #37219
Conversation
|
Size Change: +9 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
glendaviesnz
reviewed
Dec 8, 2021
This might work. Care to bet a dogecoin?
andrewserong
approved these changes
Dec 9, 2021
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Nice work! The logic looks good to me, and retrying up to a few times looks like a good way of dealing with the potential race condition, if it fails more than that many times we've probably got a bigger problem that needs investigating.
LGTM! 🎉
Contributor
|
Just adding the Backport to WP Beta/RC so that the WP release branch gets the e2e stability improvement, too 🙂 |
glendaviesnz
approved these changes
Dec 9, 2021
Contributor
glendaviesnz
left a comment
There was a problem hiding this comment.
🎉 LGTM also 🤞 this will mean a lot less e2e reruns!
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
…ent test failures (#37219) * Testing whether we can try login again after a bad nonce request * Awaiting the undoing * Retry and return This might work. Care to bet a dogecoin? * Fix linting issue and add comment to explain the need for retry Co-authored-by: Glen Davies <glen.davies@a8c.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The e2e tests intermittently fail due to some sort of race condition which causes the rest-api nonce to fail with a 400 error. This PR adds a login retry in these instances in order to make the test runs more resilient.
How has this been tested?
The e2e tests on this PR have be rerun multiple times
Props to @glendaviesnz @andrewserong @kevin940726