Site Editor: Use server definition for the Template Areas#37215
Site Editor: Use server definition for the Template Areas#37215
Conversation
| return defaultAreas.find( | ||
| ( defaultArea ) => defaultArea.area === area | ||
| ); |
There was a problem hiding this comment.
I doubt myself this morning, but this will correctly pass isShallowEqual check if the returned item is the same, right? 😄
|
Size Change: +21 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
@jameskoster, I think we should include the "Navigation" icon in the |
kevin940726
left a comment
There was a problem hiding this comment.
Didn't know that it's a thing 😆 .
Code looks good to me, haven't tested it though, but I'll just trust you on that 😛 .
Agreed. We also need to make it possible to edit the template part properties whilst editing it in focus mode. |
|
Thanks for testing, @kevin940726, and @jameskoster. I can do a quick follow-up for the Navigation icon; it should be a small PR.
Do we have an issue for this? |
|
No, I'll make one :) Edit: #37220 |
|
I'm going to merge this. Failing e2e tests is caused by a known issue - a bad request when fetching nonces. |
|
Thanks @Mamaduka! |
* Site Editor: Use server definition for the Template Areas * Simplify
Description
Closes #36955.
Updates template details components to use server-side definitions for the Template Areas. In addition, it will allow correctly displaying custom areas registered by themes. If the custom area isn't registered, it will fall back to the "General" area.
How has this been tested?
navin the area field.For testing, you can also use the Wowmall theme.
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).