Restrict template part inserter support to the site editor using filters#37065
Closed
Restrict template part inserter support to the site editor using filters#37065
Conversation
adamziel
commented
Dec 2, 2021
| 'core/edit-site/block-register', | ||
| addInsertersupportForTemplatePartBlock | ||
| ); | ||
| registerCoreBlocks(); |
Contributor
Author
There was a problem hiding this comment.
If this approach sticks, I can see moving towards a declarative approach. E.g. imagine having an editor.json like:
{
"blockOverrides": {
"core/template-part": {
"supports": {
"inserter": true
}
}
}
}Or a call like
registerCoreBlocksWithOverrides([
setBlockSupport("core/template-part", "inserter", true)
])
Contributor
There was a problem hiding this comment.
I like this idea of different per editor context. I don't want to derail the conversation as this is worth a separate issue, but how would a 3rd-party block achieve the same functionality (working only the site editor) if they can only pack their block.json settings but don't have access to the editor.json one?
|
Size Change: +73 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
priethor
reviewed
Dec 2, 2021
| 'core/edit-site/block-register', | ||
| addInsertersupportForTemplatePartBlock | ||
| ); | ||
| registerCoreBlocks(); |
Contributor
There was a problem hiding this comment.
I like this idea of different per editor context. I don't want to derail the conversation as this is worth a separate issue, but how would a 3rd-party block achieve the same functionality (working only the site editor) if they can only pack their block.json settings but don't have access to the editor.json one?
Contributor
|
Thanks for the PR Adam! This approach doesn't solve the problem now, as while we are in In general the new API that we need, will have to define what It seems that our current API I don't have a clear way forward but I think we will need involve |
Contributor
Contributor
Author
|
Closing this PR, #37157 did the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description TBD
Solves #30668