Skip to content

Templates Controller: Add missing 'is_custom' prop#36911

Merged
Mamaduka merged 2 commits intotrunkfrom
fix/template-controller-missing-prop
Nov 26, 2021
Merged

Templates Controller: Add missing 'is_custom' prop#36911
Mamaduka merged 2 commits intotrunkfrom
fix/template-controller-missing-prop

Conversation

@Mamaduka
Copy link
Copy Markdown
Member

Description

The prop was originally introduced in #35802. It returns a boolean value whether a template is a custom template and isn't part of WP default templates.

How has this been tested?

Unit tests should pass.

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka requested a review from youknowriad November 26, 2021 12:22
@Mamaduka Mamaduka self-assigned this Nov 26, 2021
@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended Backport to WP Beta/RC Core REST API Task Task for Core REST API efforts labels Nov 26, 2021
Copy link
Copy Markdown
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Mamaduka
Copy link
Copy Markdown
Member Author

Thanks, Nik. I'm going to create a core patch on Monday.

@Mamaduka Mamaduka merged commit 6466208 into trunk Nov 26, 2021
@Mamaduka Mamaduka deleted the fix/template-controller-missing-prop branch November 26, 2021 16:17
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 26, 2021
@Mamaduka Mamaduka mentioned this pull request Nov 28, 2021
7 tasks
noisysocks pushed a commit that referenced this pull request Nov 29, 2021
* Templates Controller: Add missing 'is_custom' prop

* Add prop only for wp_template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core REST API Task Task for Core REST API efforts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants