Add: Transparency support on global styles colors#36840
Merged
jorgefilipecosta merged 1 commit intotrunkfrom Nov 26, 2021
Merged
Add: Transparency support on global styles colors#36840jorgefilipecosta merged 1 commit intotrunkfrom
jorgefilipecosta merged 1 commit intotrunkfrom
Conversation
|
Size Change: +23 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Contributor
|
Tested in Chrome version 96.0.4664.45 on Windows 10: I can see the opacity option, but if I move the cursor over the larger field where I can select a new color, the entire browser window freezes and I can not mouse click on anything or navigate away. In Firefox I managed a little better: I was able to change the color twice before it crashed...
|
Member
|
I've tested this in Firefox and Chrome (Ubuntu, Linux-based OS) and it worked fine for me. In the site editor, I can see that the transparency is enabled for all element colors (both global & per block) and it isn't enabled in the block inspector. It isn't enabled either in the post editor (block inspector). |
oandregal
approved these changes
Nov 26, 2021
Member
oandregal
left a comment
There was a problem hiding this comment.
Code looks fine.
We may need to investigate further into the issue Carolina reported during the beta cycle. It may be a specific combination of OS + browser or browser version.
Member
Author
|
Thank you for reviewing this PR @oandregal! Thank you for reporting the issue @carolinan we will try to understand what's happening. I'm not able to replicate the crash yet maybe as @oandregal said it just happens on a specific OS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #36774
This PR does the following actions:
How has this been tested?
I went to the global styles sidebar. I verified I could pick a color with transparency for the global background, text, and link color.