Skip to content

Move the theme editor under tools for FSE themes#36723

Merged
youknowriad merged 1 commit intotrunkfrom
update/move-theme-editor
Nov 22, 2021
Merged

Move the theme editor under tools for FSE themes#36723
youknowriad merged 1 commit intotrunkfrom
update/move-theme-editor

Conversation

@youknowriad
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad commented Nov 22, 2021

closes #36354

I hesitated between this or removing that page entirely (because the site editor is actually a different kind of theme editor) but I guess this is less disruptive.

Testing instructions

  • Make sure the theme editor is under "tools" and not "appearance" for FSE themes.

@youknowriad youknowriad added General Interface Parts of the UI which don't fall neatly under other labels. Backport to WP Beta/RC [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Nov 22, 2021
@youknowriad youknowriad self-assigned this Nov 22, 2021
@jameskoster
Copy link
Copy Markdown
Contributor

jameskoster commented Nov 22, 2021

It works:

Screenshot 2021-11-22 at 11 27 53

We'll need to update that notice as well.

@youknowriad youknowriad merged commit 2ce3eea into trunk Nov 22, 2021
@youknowriad youknowriad deleted the update/move-theme-editor branch November 22, 2021 12:46
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 22, 2021
@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Nov 22, 2021

I see that this change has the backport to WP Beta/RC label.
Please consider the comments in the existing Trac issue: https://core.trac.wordpress.org/ticket/54382, and whether that issue should be closed or not.

@youknowriad
Copy link
Copy Markdown
Contributor Author

youknowriad commented Nov 22, 2021

Oh I didn't know about that ticket, I'm happy to follow whatever approach is agreed upon. I think the decision about this is made.

noisysocks pushed a commit that referenced this pull request Nov 23, 2021
@youknowriad @noisysocks
Move the theme editor under tools for FSE themes (#36723)
7c19bb9
@noisysocks noisysocks mentioned this pull request Nov 23, 2021
Closed
@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Nov 23, 2021 •
edited
Loading

I think the decision about this is made.

Decisions need to be announced publicly, when they are not, discussions arise in multiple places and no one is able to keep up with both Trac, Slack and GitHub. The decision making needs to be transparent, even when we are all pressed for time.

@youknowriad
Copy link
Copy Markdown
Contributor Author

youknowriad commented Nov 23, 2021

Sorry, my message had a typo :). I meant "I thought" and not "I think", sorry for the confusion due to my broken English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameskoster jameskoster jameskoster approved these changes

@ntsekouras ntsekouras ntsekouras approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@carolinan carolinan Awaiting requested review from carolinan

Assignees

@youknowriad youknowriad

Labels

[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. General Interface Parts of the UI which don't fall neatly under other labels.

Projects

None yet

Milestone

Gutenberg 12.1

Development

Successfully merging this pull request may close these issues.

Move Theme Editor to Tools when a block theme is active

5 participants

@youknowriad @jameskoster @carolinan @ntsekouras @noisysocks