[Inserter]: Adjust order of theme blocks and reorder inserter items#36719
Merged
ntsekouras merged 6 commits intotrunkfrom Nov 26, 2021
Merged
Conversation
ntsekouras
commented
Nov 22, 2021
packages/block-editor/src/components/inserter/block-types-tab.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Nov 22, 2021
packages/block-editor/src/components/inserter/block-types-tab.js
Outdated
Show resolved
Hide resolved
|
Size Change: -29 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
e7d5ab0 to
cc29be9
Compare
Contributor
|
Testing the Gutenberg PR build using https://make.wordpress.org/design/2021/03/03/testing-a-gutenberg-pull-request-pr/ This is what I see. Before:
After:
|
c10d5ec to
32a7053
Compare
Contributor
Author
|
I took the suggested block order from here: #36869. So it comes to whether we also want the block variations to be displayed right after their source blocks or not. |
cbravobernal
approved these changes
Nov 26, 2021
Contributor
cbravobernal
left a comment
There was a problem hiding this comment.
Looks good to me. Some of them I assume they are not appearing because they need to be inside the parents, right?
mtias
approved these changes
Nov 26, 2021
Contributor
Author
Right! |
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
…36719) * [Inserter]: Prioritize blocks per category in main inserter * change block categories to `theme` * Revert "[Inserter]: Prioritize blocks per category in main inserter" * reorder blocks and make variations appear right after their source block * register Navigation block earlier * reorder blocks
This was referenced Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #36547
This PR prioritizes some blocks by just changing their registration order (existing behavior).
In addition I made a change to show its block's variations right after their source block. Previously all source blocks were shown and all their variations followed, which doesn't make much sense to me :)
Testing instructions
themeblock category