Merged
Conversation
38 tasks
|
Size Change: +289 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Nov 22, 2021
| [ templateType ] | ||
| ); | ||
|
|
||
| const itemsListLabel = postType?.labels?.items_list; |
Member
There was a problem hiding this comment.
I think it would be undefined when initially rendered, that would make the labels below having something like "undefined - Header" in their strings. I wonder if we should just render null if postType isn't available yet?
Contributor
Author
There was a problem hiding this comment.
I think it's preloaded. Didn't realise it could still be null.
Wouldn't we also have this issue elsewhere in the UI?
For the sake of this PR, I'll make it fallback to the normal labels (which are just 'Header', 'Content').
Member
There was a problem hiding this comment.
Yeah probably. I think it should not be null if it's preloaded. That's a separate issue though.
noisysocks
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Implement shortcuts and labels * Use correct key for body * Fix focusing navigation sidebar when navigating regions * Only use detailed region labels when post type has loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few issues with region navigation in the site editor:
tabIndex=-1which meant it couldn't be focused when navigating regionsThe outline styles for the regions could still be improved in the site editor. I haven't tackled that in this PR, because I need to work on some other important tasks.
How has this been tested?
Testing steps depend on which OS you're using. I think on a mac it's recommended to use ctrl + ` because the alternative shortcut (ctrl+alt+n) seems to toggle a setting in voiceover that you really don't want to toggle. Also best to test in Safari on a mac.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).