Add button text when no colors found#36684
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @KevinBatdorf! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks for the PR @KevinBatdorf! This looks good to me but you may want to double-check that the e2e failures are not related to this change. |
|
Thanks @ryanwelcher. Yeah, it seems like they just timed out. I wasn't sure about the etiquette in re-running the checks since they take awhile. I'll see if I can run them again now. edit: I think someone with access will need to re-run them unless I make a trivial commit. I'll hold off on the latter. |
oandregal
left a comment
There was a problem hiding this comment.
Thanks for this contribution, Kevin.
The e2e test failures look unrelated. I've restarted. If they fail again, would you mind rebasing this branch from trunk and pushing the changes again?
|
Congratulations on your first merged pull request, @KevinBatdorf! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Description
From #36543 I've added a CTA text for when the color palette has 0 colors.
From the linked issue:
How has this been tested?
I tested this manually by adding/removing colors.
Screenshots
When colors is 0
When colors > 0
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).--
N.B. It looks like Prettier is pushing the arguments passed in to
sprintftwo tabs deep instead of a single tab when paired with a ternary. I've seen this elsewhere in the codebase here so may require a patch to Prettier.