Only render the site editor canvas when the global styles are ready.#36643
Merged
youknowriad merged 2 commits intotrunkfrom Nov 19, 2021
Merged
Only render the site editor canvas when the global styles are ready.#36643youknowriad merged 2 commits intotrunkfrom
youknowriad merged 2 commits intotrunkfrom
Conversation
|
Size Change: +16 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Nov 19, 2021
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
It's working well for me. No flash of un-styled canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #36594
While previously, we had a behavior in place to wait for "user global styles" to be loaded, we didn't have the same behavior for the "base global styles" that come directly from theme.json, meaning it was possible to notice a switch in the applied styled in the site editor canvas after some milliseconds.
I also noticed that the base styles where not reloaded properly (wrong url used there). This PR solves both of these issues.
Testing instructions