Fix page list missing button styles when set to open on click.#36601
Merged
Fix page list missing button styles when set to open on click.#36601
Conversation
|
Size Change: -325 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Nov 19, 2021
Contributor
carolinan
left a comment
There was a problem hiding this comment.
Buttons in the page list looks much better now, thank you.
No issues found with the submenu block buttons.
Contributor
Author
|
I'll rebase and land this one. |
dcf3b3e to
7453fc3
Compare
7453fc3 to
c672b1a
Compare
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36599.
The stylesheet containing styles to unset the border appearance of the
buttonelement used for the Submenu block are tied directly to that block. Which means if you set the Page List block to open submenus on click, those styles are missing:This PR moves those submenu styles to the navigation block itself, so that the navigation block conducts the apperance of its contents:
This feels appropriate, especially since the Submenu block can't be used outside of Navigation.
How has this been tested?
Make sure you have published pages on your site that include submenus. Insert a navigation block with a Page List and set it to open on click. The submenu button should look
Checklist:
*.native.jsfiles for terms that need renaming or removal).