Add page list to navigation direct insert conditions#36591
Merged
tellthemachines merged 1 commit intotrunkfrom Nov 18, 2021
Merged
Add page list to navigation direct insert conditions#36591tellthemachines merged 1 commit intotrunkfrom
tellthemachines merged 1 commit intotrunkfrom
Conversation
45 tasks
|
Size Change: +4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 18, 2021
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
I love tiny PRs like these 👌
Works as intended. Before:
After:
The change makes sense for us to try, as when you're looking at a menu with only menu items, you'd expect it to behave like the other manually curated menus you've created.
As part of the rolling out of the navigation block, I suspect we'll get a slew of good feedback, and depending on that we can always revisit this one. But it seems good to start with this one as a baseline.
Thank you!
getdave
approved these changes
Nov 18, 2021
Contributor
getdave
left a comment
There was a problem hiding this comment.
Looks good. Makes a big different to positive UX. Glad it was such a quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is only possible to directly insert links in the Navigation block if there are only link or submenu items in it. This PR adds Page List to those items, so that links can also be directly inserted when the nav has a page list in it.
How has this been tested?
Create a Navigation block, choosing "Add all pages" option. Verify that clicking the inserter adds a link block directly, instead of showing the quick inserter.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).