Multi-entity save: Only set site entity to pending if really saving#36573
Merged
Multi-entity save: Only set site entity to pending if really saving#36573
Conversation
|
Size Change: +4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Addison-Stavlo
approved these changes
Nov 17, 2021
Contributor
Addison-Stavlo
left a comment
There was a problem hiding this comment.
That was my oversight, nice catch and thank you for fixing this! The changes here look good and test as expected!
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
…36573) Currently, the multi-entity save panel is unconditionally attempting to save changes to the site entity, even if there aren't any. This causes the site entity saving state to be set to "pending" at least for a short period of time. This commit makes it so that we only save the site entity if there are any changes to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the multi-entity save panel is unconditionally attempting to save changes to the site entity, even if there aren't any. This causes the site entity saving state to be set to "pending" at least for a short period of time.
This PR makes it so that we only save the site entity if there are any changes to it.
I'm not aware of bugs resulting directly from this, but I've noticed that it would affect checkboxes shown in the discard panel introduced in #36185. Furthermore, the erroneous behavior was found by @ramonjd in #36096 (comment) (although it doesn't seem to be the root cause for #36096).
How has this been tested?
corestore, and filter for theSAVE_ENTITY_RECORD_STARTaction. Verify that there are no such actions affecting the site entity (root.entities.data.root.site.saving).(Compare to
trunkwhere there areSAVE_ENTITY_RECORD_STARTthat affect that part of the state tree.)Types of changes
Bug fix