Site Editor: Stabilize export endpoint#36559
Merged
Conversation
Restore 'gutenberg_generate_edit_site_export_file'
|
Size Change: -226 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Member
Author
|
I've not added endpoint unit tests yet. Do we have any existing tests for "download" response types in WP Core that I can use as a base? |
walbo
reviewed
Nov 17, 2021
lib/compat/wordpress-5.9/class-wp-rest-edit-site-export-controller.php
Outdated
Show resolved
Hide resolved
walbo
approved these changes
Nov 17, 2021
Member
walbo
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested with TT2 and a custom block based theme and the export function works as expected.
Member
|
One last thing. Should |
Member
I think it's preferable that it is a global function. That means it can be used by other developers in things like WP CLI commands. |
Member
Author
|
Thanks for testing, @walbo
That was my initial thought, but then I realized we'd lose all unit tests for this feature. @TimothyBJacobs, that's also a good point for keeping it global. Any suggestions regarding my previous comments - #36559 (comment)? |
Member
|
In an ideal world we'd be able to return a response object, but for now the REST server will always try to encode the response data as JSON. In the future, we could make this optional if there is a So for now, as long as it has been tested manually, I think it's probably fine to leave the REST API endpoint itself without unit tests. It could be a good candidate for e2e tests perhaps? |
Member
Author
|
Thanks for the clarification, @TimothyBJacobs. We already have E2E tests for the Export feature. |
Member
|
Great! |
Member
Author
|
@noisysocks I'm adding the "Backport" label, but I will follow up with the core path myself. |
Member
Author
|
@noisysocks, ignore my previous comment 😅 We need to backport this because of a small change in the JS file. |
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Site Editor: Stabilize export endpoint * Move '_remove_theme_attribute_from_content' in block template utils Restore 'gutenberg_generate_edit_site_export_file' * Delete temp file after export * Use ZipArchive::open to create export file * Move gutenberg_generate_edit_site_export_file into 5.9 compat dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes site editor export endpoint and updates to use
WP_REST_Controller.PR also moves
_remove_theme_attribute_in_block_template_contentintoblock-template-utils.php.Fixes #36515.
How has this been tested?
All tests are passing.
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).