Add feature flag to toggle the new site editor sidebar#36516
Merged
andrewserong merged 1 commit intotrunkfrom Nov 16, 2021
Merged
Add feature flag to toggle the new site editor sidebar#36516andrewserong merged 1 commit intotrunkfrom
andrewserong merged 1 commit intotrunkfrom
Conversation
|
Size Change: +4.83 kB (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Nov 16, 2021
Contributor
jameskoster
left a comment
There was a problem hiding this comment.
Works as advertised.
The feature flag makes sense to me, as it allows us to enable the new template list at the same time as disabling this one.
andrewserong
approved these changes
Nov 16, 2021
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Thanks @kevin940726, this looks like a good way to revert it. I've tested this in isolation and cherry picked on top of release/11.9 and it seems to work well, I think it'll be a good one for inclusion in an 11.9 point release. I'll merge this in and then cherry pick.
Cheers!
Contributor
|
This PR was cherry picked into the GB 11.9.1 point release in 1551934 |
|
I noticed that all templates that are alphabetically after "Page" (e.g. search, single) are not available in the sidebar. Not too sure whether to open a new issue, or is this comment sufficient? |
|
Please disregard my previous comment. It is not as simple an issue as I first thought. Taking Twenty Twenty-Two theme, and adding Doing the same in another theme, bumps both This is very strange, and needs more of a deep dive to find out what is happening. |
| settings.__experimentalFetchRichUrlData = fetchUrlData; | ||
| settings.__experimentalSpotlightEntityBlocks = [ 'core/template-part' ]; | ||
| // Feature flag for the new menu sidebar which isn't stable yet. | ||
| settings.__experimentalNewMenuSidebar = false; |
Contributor
There was a problem hiding this comment.
Im curious why this is hardcoded here as false as opposed to initialized as false on the php side for the settings that are passed into this init function. With the former, the nav sidebar is always there without making direct changes to the build. With the latter, we could filter this setting and have it either way?
Member
Author
There was a problem hiding this comment.
This is just a temporary solution and I don't want to make it too easy to change that. It wouldn't be here for too long anyway. Also, I think you could do wp.data.dispatch( editSiteStore ).updateSettings() to switch this flag using JS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a feature flag to revert #36194 to the old navigation panel in site editor.
This is meant to be a temporary solution until #36379 is merged. And we can still develop the new screen by switching the flag.
How has this been tested?
tt1-blocks__experimentalNewMenuSidebartotrueinedit-site/src/index.jsand reloadTypes of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).