Make Reusable blocks available in the Site Editor#36511
Merged
noisysocks merged 8 commits intotrunkfrom Nov 24, 2021
Merged
Conversation
|
Size Change: +335 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
45 tasks
Contributor
Author
|
I've been very busy. Going to pick this up again Monday morning GMT. |
getdave
commented
Nov 19, 2021
| "yauzl": "^2.7.0" | ||
| }, | ||
| "dependencies": { | ||
| "are-we-there-yet": { |
Contributor
Author
There was a problem hiding this comment.
I spoke to @gziolo about this. I have no idea why it's happening.
Member
There was a problem hiding this comment.
Try deleting node_modules and running npm install again.
Member
|
How's this going @getdave? Need help? |
Contributor
Author
I was sidetracked yesterday wrangling Navigation block but will take another look today. Help is very welcome here. |
1e15eaf to
be5b854
Compare
Contributor
Author
|
Currently looking out for edge cases on this. I suspect enabling Reusable blocks within Template Parts might throw up problems. |
youknowriad
reviewed
Nov 23, 2021
Contributor
|
I have followed the testing instructions above and I also tested:
Newly created reusable blocks are not listed in the inserters unless I refresh the page. Perhaps that is unrelated. I did not do a code review. |
Contributor
That's related, the |
Contributor
Author
👍 Addressed in 03b9dc8. |
youknowriad
reviewed
Nov 23, 2021
youknowriad
approved these changes
Nov 23, 2021
This reverts commit c11a2490ddf4b0af3a78e68d87af4a8b8345f171.
e14baf7 to
e362a18
Compare
Contributor
Author
|
Looks like a problem with the |
Contributor
Author
Nice one @noisysocks. I was hesitant about the best course of action what with all the |
7 tasks
noisysocks
added a commit
that referenced
this pull request
Nov 29, 2021
* Create new selector to fetch reusable blocks to be exposed on block editor settings * Add Reusable Blocks meun items * Avoid expose new selector as part of API #36511 (comment) * Revert "Avoid expose new selector as part of API" This reverts commit c11a2490ddf4b0af3a78e68d87af4a8b8345f171. * Pass reusable blocks getting as selector dependency * Add unit test for Reusable blocks selector * Fix tests * rm -rf node_modules; npm install Co-authored-by: Robert Anderson <robert@noisysocks.com>
33 tasks
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #30669 we learnt that Reusable Blocks aren't currently available in the Site Editor. This PR enables them in the Site Editor.
Closes #30669
How has this been tested?
Screenshots
Screen.Capture.on.2021-11-23.at.12-01-06.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).