Revert "theme.json: adds a setting property that enables some other ones"#36477
Merged
noisysocks merged 1 commit intotrunkfrom Nov 15, 2021
Merged
Conversation
This reverts commit ed922a1.
noisysocks
added a commit
that referenced
this pull request
Nov 15, 2021
This was referenced Nov 15, 2021
oandregal
added a commit
that referenced
this pull request
Nov 19, 2021
Member
|
Second try at #36646 |
Member
|
#36646 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry @oandregal, merging this caused legitimate PHP unit test failures on
trunk. I'm not sure why they were passing in the PR. Please revert this revert, fix up the tests, and I'll backport that into the 5.9 branch in time for Beta 2.Reverts #36246