Skip to content

Fix background colours in nested submenus.#36476

Merged
tellthemachines merged 1 commit intotrunkfrom
fix/submenu-background
Nov 17, 2021
Merged

Fix background colours in nested submenus.#36476
tellthemachines merged 1 commit intotrunkfrom
fix/submenu-background

Conversation

@tellthemachines
Copy link
Copy Markdown
Contributor

Description

Fixes #36427 and #36439.

The background colour classnames weren't rendering on the front end due to a attribute name error in the block PHP.

How has this been tested?

In a Navigation block with nested Submenus, change the Overlay background colour to a non-default value. Make sure the Background colour value is set to default. Publish and check that overlay background colour applies to all the submenus on the front end.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@tellthemachines tellthemachines added [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Bug An existing feature does not function as intended Backport to WP Beta/RC labels Nov 15, 2021
Copy link
Copy Markdown
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Screenshot 2021-11-15 at 09 07 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Bug An existing feature does not function as intended

Projects

None yet

3 participants