Account for upcoming changes in styles metadata in WordPress 5.9#36327
Merged
Account for upcoming changes in styles metadata in WordPress 5.9#36327
Conversation
Contributor
|
This tests as advertised for me. ✅ Code changes LGTM. Types match the core PR. I'd be inclined to approve this one however it might be good to get a second opinion first. |
74fa25e to
4888cb5
Compare
4888cb5 to
a05a7a2
Compare
aristath
approved these changes
Dec 9, 2021
Member
aristath
left a comment
There was a problem hiding this comment.
Code looks good, works as expected 👍
a05a7a2 to
262e33e
Compare
Member
Author
|
I see a few e2e test failures. They're related to multi-block selection FAIL specs/editor/various/multi-block-selection.test.js (127.811 s)
● Multi-block selection › should return original focus after failed multi selection attempt
expect(received).toMatchSnapshot()
Snapshot name: `Multi-block selection should return original focus after failed multi selection attempt 1`
- Snapshot - 1
+ Received + 1
<!-- wp:paragraph -->
- <p>2</p>
+ <p>12</p>
<!-- /wp:paragraph -->
506 | await page.keyboard.press( 'Backspace' );
507 |
> 508 | expect( await getEditedPostContent() ).toMatchSnapshot();
| ^
509 | } );
510 |
511 | it( 'should preserve dragged selection on move', async () => {
at Object.<anonymous> (specs/editor/various/multi-block-selection.test.js:508:42)
at runMicrotasks (<anonymous>)
● Multi-block selection › should clear selection when clicking next to blocks
Execution context was destroyed, most likely because of a navigation.
555 |
556 | // Wait for blocks to have updated asynchronously.
> 557 | await page.evaluate( () => new Promise( window.requestIdleCallback ) );
| ^
558 | await testNativeSelection();
559 | expect( await getSelectedFlatIndices() ).toEqual( [] );
560 |
at rewriteError (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:322:15)
at runMicrotasks (<anonymous>)
at ExecutionContext._evaluateInternal (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:271:7)
at ExecutionContext.evaluate (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:140:12)
at Object.<anonymous> (specs/editor/various/multi-block-selection.test.js:557:3)
● Multi-block selection › should select all from empty selection
Execution context was destroyed, most likely because of a navigation.
at rewriteError (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:322:15)
at runMicrotasks (<anonymous>)
at ExecutionContext._evaluateInternal (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:271:7)
at ExecutionContext.evaluate (../../node_modules/puppeteer-core/src/common/ExecutionContext.ts:140:12)
at emulateSelectAll (../e2e-test-utils/build/@wordpress/e2e-test-utils/src/press-key-with-modifier.js:25:2)
at pressKeyWithModifier (../e2e-test-utils/build/@wordpress/e2e-test-utils/src/press-key-with-modifier.js:145:10)
at Object.<anonymous> (specs/editor/various/multi-block-selection.test.js:727:3) |
262e33e to
c56bf45
Compare
Member
Yeah, I see the same... but they don't feel related. 🤔 Update: The same tests fail after rebasing the PR so it has to be related to the changes here somehow |
4273e42 to
cd13eb3
Compare
Member
Author
|
Executing |
cd13eb3 to
af21791
Compare
Member
|
As far as I can see, this change changes the styling (which seems unexpected?) so that there's no space between the canvas and the blocks. That's why some tests are failing.
|
Member
|
It seems to me that theme styles are no longer loaded. |
Member
Author
|
🤔 This is what I see when I run the tests in interactive mode (styles properly loaded):
|
af21791 to
67001f9
Compare
67001f9 to
e22e9d7
Compare
e22e9d7 to
12e4913
Compare
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WordPress/wordpress-develop#1831
In that core PR, we're updating the metadata to "signal" the different kinds of styles the client may receive. It was
globalStylesin WordPress 5.8 and it'll bethemeorpresetsin WordPress 5.9. This PR makes Gutenberg work with any of those core versions.How to test
Load the editor and verify that the styles look as expected for the following setups: