Cover Block: Fix default background dim#36312
Merged
fullofcaffeine merged 1 commit intotrunkfrom Nov 8, 2021
Merged
Conversation
|
Size Change: +8 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
fullofcaffeine
approved these changes
Nov 8, 2021
Member
fullofcaffeine
left a comment
There was a problem hiding this comment.
Just to clarify - the issue only happens with the default black dim that's added just after you add the Cover block, which was lost before this fix. That being said, this tests well!
fullofcaffeine
pushed a commit
that referenced
this pull request
Nov 8, 2021
fullofcaffeine
pushed a commit
that referenced
this pull request
Nov 8, 2021
41 tasks
32 tasks
7 tasks
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
|
Hi @noisysocks, It seems that this PR wasn't backported in WP 5.9 RC2.
|
Contributor
|
@dianeco Thanks for reporting this. I wasn't able to replicate it: Are you able to share the block markup of both versions, ie. copy and paste ` chunk from editor code view from 5.8.3 and then after reloading the editor in 5.9? It might be a combination of the attributes you have set for the cover that is causing this to happen in your instance. @noisysocks I have checked and it looks like this patch is included in 5.9 as the default dimRatio of 50 is applied when adding a new cover with media. |
|
@glendaviesnz I discovered an issue and maybe wrongly assumed that this PR was fixing it. My issue is that the overlay opacity on covers previously created with WP 5.8 isn't applied in WP 5.9 RC 2 (and Gutenberg). To reproduce:
Let me know if I should open a new issue. |
Member
|
WP 5.9 includes all versions ≤ Gutenberg 11.9, so this PR will have automatically been included. @dianeco: Yes, please create an issue 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #35065, the default background dim for the Cover block disappeared. This PR fixes it.
What caused the bug?
In #35065 we changed the Cover block's markup which caused the
has-background-dimclass to not take effect anymore as it's no longer paired with the top-levelwp-block-coverclass. This PR fixes thehas-background-dimclass dependency.Default Cover block's markup before #35065:
Default Cover block's markup after #35065:
Fixes #36310
How has this been tested?
trunknpx wp-env start && npm run dev)Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).