Description

enablePageDialogAccept is enabled in setup-test-framework which auto-accepts all dialogs on the page. I think this is overly aggressive and there's currently no way to disable it either.

This had been brought up in WordPress/wordpress-develop#1746 (comment), which at first was very confusing why the dialog kept closing automatically. I believe this method was originally introduced to automatically accept only the "Are you sure you want to leave before saving" dialogs, maybe we should target that individually instead of aggressively closing all dialogs?

Either way, I think it makes sense to still provide a method to disable this functionality. Hence, this PR adds a new API disablePageDialogAccept which will do exactly that.

How has this been tested?

Create a new test somewhere with the following content and run it.

it( 'test confirm', async () => {
	disablePageDialogAccept();

	const dialog = await new Promise( ( resolve ) => {
		page.once( 'dialog', resolve );
                 // alert() will pause the execution of JS,
                 // so the promise will never resolve until we call dialog.accept().
		page.evaluate( () => alert( 'ALERT' ) );
	} );

	expect( dialog.message() ).toBe( 'ALERT' );

	await dialog.accept();
} );

Types of changes

New feature

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).