UnitControl: Set correct unit when units has one option#33634
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Jul 23, 2021
Merged
UnitControl: Set correct unit when units has one option#33634Mamaduka merged 1 commit intoWordPress:trunkfrom
Mamaduka merged 1 commit intoWordPress:trunkfrom
Conversation
7 tasks
Contributor
|
Thanks for fixing this issue @walbo. I was also looking into this problem but you were too quick for me 🚀 Our solutions were pretty similar the only difference being that if we are changing the behaviour of the I've created a quick PR to address adding explicit checks for |
Member
Author
|
Thanks for the follow-up @aaronrobertshaw 👍 Didn't spot that one. |
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When only one option is passed to the
unitsprop inUnitControlcomponent theonChangealways returnspx.Ex on pattern that will return
px:How has this been tested?
Testet with both multiple and single option in
unitsprop.Screenshots
Before
After
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).