[RNMobile][Embed Block] Fix loading glitch#33574
Merged
Conversation
|
Size Change: +307 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
fluiddot
reviewed
Jul 20, 2021
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 26, 2021
This was referenced Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes error state appearing for a brief moment when the embed URL is edited and loading is triggered.
How has this been tested?
Invalid URL cases
Empty URL cases
Valid URL cases
Screenshots
Before
embed-glitch.mp4
After
embed-glitch-fixed.mp4
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).