Avoid calling gutenberg_ functions within code shipped through WordPress Core#33331
Merged
youknowriad merged 18 commits intotrunkfrom Jul 13, 2021
Merged
Avoid calling gutenberg_ functions within code shipped through WordPress Core#33331youknowriad merged 18 commits intotrunkfrom
gutenberg_ functions within code shipped through WordPress Core#33331youknowriad merged 18 commits intotrunkfrom
Conversation
…e-gutenberg_-prefix-from-core-code
youknowriad
reviewed
Jul 12, 2021
youknowriad
reviewed
Jul 13, 2021
youknowriad
reviewed
Jul 13, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
Contributor
|
Yep, looks good here too. Thanks @desrosj and @youknowriad. |
mcsf
reviewed
Jul 16, 2021
7 tasks
12 tasks
ntsekouras
added a commit
that referenced
this pull request
Aug 5, 2021
* Check for the correct function. * add prefix Co-authored-by: ntsekouras <ntsekouras@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adjusts the code for the
render_block_core_legacy_widget()function to remove thegutenberg_specific functions referenced. Because the PHP file is copied directly into WordPress Core when runningnpm run build, the changes need to be made in the Gutenberg repo.Plugin specific code should not be included in Core code unless completely unavoidable.
See: https://core.trac.wordpress.org/ticket/53610.
Checklist:
*.native.jsfiles for terms that need renaming or removal).