Specify what settings can be part of settings.layout#33303
Merged
Conversation
youknowriad
reviewed
Jul 8, 2021
| ), | ||
| 'custom' => null, | ||
| 'layout' => null, | ||
| 'layout' => array( |
Contributor
There was a problem hiding this comment.
I think later we'll have "type" and a different shape of layout depending of the "type". Maybe it's fine for now to have this but I thought I'd mention in case it's any impactful.
Member
Author
There was a problem hiding this comment.
When/If we have those new fields we can add them all and/or have some specific logic for layout to make sure only the ones that make sense depending on type are allowed.
By porting this to WordPress core we won't allow anything else than what it's shipped in v1 (the two fields in use atm) without the plugin. With the plugin, consumers will have those new things available. Makes sense?
aristath
approved these changes
Jul 9, 2021
5a7da4e to
3493a0a
Compare
youknowriad
pushed a commit
that referenced
this pull request
Jul 12, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stems from #33280
This PR makes it so that only the specific allowed settings can be part of
settings.layout.