Fix moving inner blocks in the Widgets Customizer#33243
Merged
noisysocks merged 2 commits intotrunkfrom Jul 8, 2021
Merged
Conversation
|
Size Change: +99 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Jul 7, 2021
noisysocks
approved these changes
Jul 8, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 12, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A inner block is never created as a widget, but the current way of moving them only works with a
widget with
widgetId. To solve this, we create a new widget of that block upon moving.This also fixes a bug with focus when moving blocks. This was originally fixed in #31308 but I forgot to pick it up while rebasing 😅 .
How has this been tested?
Added e2e test, or:
Screenshots
Kapture.2021-07-07.at.14.12.23.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).